Ad5001/LogarithmPlotter
Ad5001/LogarithmPlotter
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Wiki Activity

Fixing expression being set even if errors are found.
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source
This commit is contained in:
Adsooi 2022-10-20 17:39:36 +02:00
parent 7e427e5bb9
commit 356169c749
Signed by: Ad5001
GPG key ID: 7251B1AF90B960F9
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
LogarithmPlotter/qml/eu/ad5001/LogarithmPlotter/Setting/ExpressionEditor.qml
View file

@ -475,12 +475,13 @@ Item {
} }
if(expr.requiredObjects().includes(control.self)) if(expr.requiredObjects().includes(control.self))
throw new Error(qsTranslate('error', 'Object cannot be dependent on itself.')) throw new Error(qsTranslate('error', 'Object cannot be dependent on itself.'))
// TODO: Check for recursive dependencies. // TODO: Check for recursive dependencies.
return expr
} catch(e) { } catch(e) {
// Error in expression // Error in expression
parsingErrorDialog.showDialog(propertyName, newExpression, e.message) parsingErrorDialog.showDialog(propertyName, newExpression, e.message)
return null
} }
return expr
} }
/*! /*!